feat(ironic): harden graphical console input - #4239
Conversation
|
@codex[agent] review this PR |
|
Rico Lin (@ricolin) Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Rico Lin (@ricolin) Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
4 similar comments
|
Rico Lin (@ricolin) Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
Rico Lin (@ricolin) Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
Rico Lin (@ricolin) Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
Rico Lin (@ricolin) Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
127bae9 to
0124af0
Compare
29ebe91 to
5f40747
Compare
Add provider-neutral keyboard pacing, diagnostics, and timing controls to dynamic console Pods. Pass the controls to the backend selected through the centralized Atmosphere image catalog. Change-Id: I192c715235aff1f0ebcb36f5db4b9c7415b0d859 Signed-off-by: Rico Lin <rlin@vexxhost.com> Assisted-By: Codex <noreply@openai.com>
5f40747 to
5f8eca3
Compare
2 participants
Summary
Add provider-neutral keyboard pacing and bounded key timing controls for dynamic Ironic graphical-console Pods.
The selected
atmosphere_images.ironic_consolebackend receives:KEYBOARD_MODEKEYBOARD_DIAGNOSTICSPRINTABLE_KEY_HOLDPRINTABLE_KEY_INTERVALDiagnostics remain disabled by default and record aggregate input counts only. Backend and noVNC browser-asset selection remain deployment concerns through
atmosphere_image_overrides.Dependency
This PR is stacked on #4236 because it extends the hardened graphical-console lifecycle and backend contract introduced there.
Validation
go test ./roles/ironichelm unittest -f '../../roles/ironic/tests/*.yaml' charts/ironicgit diff --check